Skip to content

chore: bump semantic-release to 19.0 #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Feb 16, 2022

Summary

This will also address GHSA-rrrm-qjm4-v8hf

Test Plan

n/a

@tido64 tido64 requested a review from krizzu February 16, 2022 13:57
Base automatically changed from tido/address-security to master February 17, 2022 16:37
@tido64 tido64 force-pushed the tido/bump-semantic-release branch from 59d0d72 to 3f20607 Compare February 17, 2022 17:02
"typescript": "^4.5.0"
},
"resolutions": {
"npm/chalk": "^4.1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it dependency of semantic-release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this issue in another repo where the latest version of semantic-release bumped npm, which has a dependency on chalk@*, and because chalk@5 is ESM only, the pipeline failed because npm can't import it.

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tido64 tido64 merged commit e1640f1 into master Feb 18, 2022
@tido64 tido64 deleted the tido/bump-semantic-release branch February 18, 2022 08:48
@krizzu
Copy link
Member

krizzu commented Mar 15, 2022

🎉 This PR is included in version 1.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants